coding style in question_frontend.py

[lilass.git] / gui.py

diff --git a/gui.py b/gui.py
index c1f045d6c1d5ecdeae46f46307c821aaa73f9386..16224107e429824d6469be35c5c8610138499dc0 100644 (file)
--- a/gui.py
+++ b/gui.py
@@ -31,6 +31,10 @@ def setup(internalResolutions, externalResolutions):
 '''
 import subprocess, collections
 
+from cli_frontend import CLIFrontend
+from zenity_frontend import ZenityFrontend
+from screen import processOutputIt
+
 # Qt frontend
 class QtFrontend:
     def __init__(self):
@@ -54,39 +58,6 @@ class QtFrontend:
         except ImportError:
             return False
 
-
-# Zenity frontend
-class ZenityFrontend:
-    def error(message):
-        '''Displays a fatal error to the user'''
-        subprocess.check_call(["zenity", "--error", "--text="+message])
-    
-    def setup(self, situation):
-        from zenity_dialogue import run
-        return run(situation.internalResolutions(), situation.externalResolutions())
-    
-    @staticmethod
-    def isAvailable():
-        try:
-            from dsl import processOutputIt
-            processOutputIt("zenity", "--version")
-            return True
-        except Exception:
-            return False
-
-
-# CLI frontend
-class CLIFrontend:
-    def error(self, message):
-        print(message, file=sys.stderr)
-    
-    def setup(self, internalResolutions, externalResolutions, commonRes):
-        raise Exception("Choosing the setup interactively is not supported with the CLI frontend")
-    
-    @staticmethod
-    def isAvailable():
-        return True
-
 # list of available frontends
 frontends = collections.OrderedDict()
 frontends["qt"] = QtFrontend
@@ -100,8 +71,10 @@ def getFrontend(name = None):
         if name in frontends:
             if frontends[name].isAvailable():
                 return frontends[name]() # call constructor
-        # frontend not found or not available
-        raise Exception("Frontend %s not found or not available" % name)
+            else:
+                raise Exception("Frontend %s not available" % name)
+        # frontend not found
+        raise Exception("Frontend %s not found" % name)
     # auto-detect
     for frontend in frontends.values():
         if frontend.isAvailable():