Move the GUI frontend doc out of the Qt implementation

[lilass.git] / zenity_dialogue.py

diff --git a/zenity_dialogue.py b/zenity_dialogue.py
index 45cf557a9bea9edbca5b744bee84f094c7f79090..69365e8325d8c8882f06450ca3f28ec5e0f1b6ee 100644 (file)
--- a/zenity_dialogue.py
+++ b/zenity_dialogue.py
@@ -22,7 +22,7 @@ def userChoose (title, choices, returns, fallback):
        assert len(choices) == len(returns)
        p = subprocess.Popen(["zenity", "--list", "--text="+title, "--column="]+choices, stdout=subprocess.PIPE)
        switch = dict (zip (choices,returns))
-       for line in p.stdout:
+       for line in p.stdout: # FIXME use p.communicate()[0] instead to get entire stdout and ensure the process terminates. also check p.returncode.
                return switch.get(line.strip(), fallback)
        return fallback