Complain about unknown xrandr output

[lilass.git] / dsl.py

diff --git a/dsl.py b/dsl.py
index dad969abdaebe9cce52044fa99d4703d1af4906b..0704d3e8f3da546f9b5e510976cf98bcbebe328a 100755 (executable)
--- a/dsl.py
+++ b/dsl.py
@@ -21,7 +21,7 @@ from selector_window import PositionSelection
 import gui
 
 # for auto-config: common names of internal connectors
-commonInternalConnectorNames = ['LVDS', 'LVDS1']
+commonInternalConnectorNames = ['LVDS', 'LVDS0', 'LVDS1', 'LVDS-0', 'LVDS-1']
 
 # Load a section-less config file: maps parameter names to space-separated lists of strings (with shell quotation)
 def loadConfigFile(file):
@@ -49,21 +49,33 @@ def loadConfigFile(file):
 def getXrandrInformation():
        p = subprocess.Popen(["xrandr", "-q"], stdout=subprocess.PIPE)
        connectors = {} # map of connector names to a list of resolutions
-       connector = None # current connector
-       for line in p.stdout:
-               # new connector?
-               m = re.search(r'^([\w]+) (dis)?connected ', line)
-               if m is not None:
-                       connector = m.groups()[0]
-                       assert connector not in connectors
-                       connectors[connector] = []
-                       continue
-               # new resolution?
-               m = re.search(r'^   ([\d]+)x([\d]+) +', line)
-               if m is not None:
-                       assert connector is not None
-                       connectors[connector].append((int(m.groups()[0]), int(m.groups()[1])))
-       p.communicate()
+       try:
+               connector = None # current connector
+               for line in p.stdout:
+                       # screen?
+                       m = re.search(r'^Screen [0-9]+: ', line)
+                       if m is not None: # ignore this line
+                               connector = None
+                               continue
+                       # new connector?
+                       m = re.search(r'^([\w\-]+) (dis)?connected ', line)
+                       if m is not None:
+                               connector = m.groups()[0]
+                               assert connector not in connectors
+                               connectors[connector] = []
+                               continue
+                       # new resolution?
+                       m = re.search(r'^   ([\d]+)x([\d]+) +', line)
+                       if m is not None:
+                               assert connector is not None
+                               connectors[connector].append((int(m.groups()[0]), int(m.groups()[1])))
+                               continue
+                       # unknown line
+                       raise Exception("Unknown line in xrandr output:\n"+line)
+       finally:
+               # be sure to always proprly finish up with the xrandr
+               p.communicate()
+       # if everything succeededso far, check return code
        if p.returncode != 0: raise Exception("Querying xrandr for data failed.")
        return connectors
 
@@ -83,9 +95,9 @@ def res2user(res):
                strRatio = '16:%d' % ratio
        return '%dx%d (%s)' %(w, h, strRatio)
 
-def findAvailableConnector(tryConnectors):
+def findAvailableConnector(tryConnectors, allConnectors):
        for connector in tryConnectors:
-               if connector in connectors and connectors[connector]: # if the connector exists and is active (i.e. there is a resolution)
+               if connector in allConnectors and allConnectors[connector]: # if the connector exists and is active (i.e. there is a resolution)
                        return connector
        return None
 
@@ -103,7 +115,7 @@ def main():
                        raise Exception("Connector %s does not exist, there is an error in your config file." % internalConnector)
        else:
                # auto-config
-               internalConnector = findAvailableConnector(commonInternalConnectorNames)
+               internalConnector = findAvailableConnector(commonInternalConnectorNames, connectors)
                if internalConnector is None:
                        raise Exception("Could not automatically find internal connector, please use ~/.dsl.conf to specify it manually.")
        # all the rest is external then, obviously - unless the user wants to do that manually
@@ -124,7 +136,7 @@ def main():
                args[c] = ["--off"]
 
        # Check what to do
-       usedExternalConnector = findAvailableConnector(externalConnectors) # *the* external connector which is actually used
+       usedExternalConnector = findAvailableConnector(externalConnectors, connectors) # *the* external connector which is actually used
        if usedExternalConnector is not None: # there's an external screen connected, we need to ask what to do
                internalResolutions = connectors[internalConnector]
                externalResolutions = connectors[usedExternalConnector]