Wait a bit more before starting to complain

[saartuer.git] / libtuer.py

diff --git a/libtuer.py b/libtuer.py
index 097a25abb6894eb1079cfe26802f7fd876d0ebe8..c9eceec42fa99ae4537563a62002300516485f86 100644 (file)
--- a/libtuer.py
+++ b/libtuer.py
@@ -5,12 +5,13 @@ import email.mime.text, email.utils
 # Logging configuration
 syslogLevel = logging.INFO
 mailLevel   = logging.CRITICAL # must be "larger" than syslog level!
-mailAddress = ['post+tuer'+'@'+'ralfj.de', 'vorstand@lists.hacksaar.de']
+from config import mailAddress
 printLevel  = logging.DEBUG
 
 # Mail logging handler
 def sendeMail(subject, text, receivers, sender='sphinx@hacksaar.de', replyTo=None):
-       if not isinstance(type(receivers), list): receivers = [receivers]
+       assert isinstance(receivers, list)
+       if not len(receivers): return # nothing to do
        # construct content
        msg = email.mime.text.MIMEText(text.encode('UTF-8'), 'plain', 'UTF-8')
        msg['Subject'] = subject
@@ -57,16 +58,27 @@ class Logger:
 
 logger = Logger()
 
+# run a Python command asynchronously
+def fire_and_forget(f):
+       def _fire_and_forget():
+               try:
+                       f()
+               except Exception as e:
+                       logger.critical("fire_and_forget: Got exception out of callback: %s" % str(e))
+                       logger.debug(traceback.format_exc())
+       t = threading.Thread(target=_fire_and_forget)
+       t.start()
+
 # run a command asynchronously and log the return value if not 0
 # prefix must be a string identifying the code position where the call came from
-def fire_and_forget (cmd, log, prefix):
-       def _fire_and_forget ():
+def fire_and_forget_cmd (cmd, log_prefix):
+       logger.debug("Firing and forgetting command from %s: %s" % (log_prefix,str(cmd)))
+       def _fire_and_forget_cmd ():
                with open("/dev/null", "w") as fnull:
                        retcode = subprocess.call(cmd, stdout=fnull, stderr=fnull)
                        if retcode is not 0:
-                               logger.error("%sReturn code %d at command: %s" % (prefix,retcode,str(cmd)))
-       t = threading.Thread(target=_fire_and_forget)
-       t.start()
+                               logger.error("%sReturn code %d at command: %s" % (log_prefix,retcode,str(cmd)))
+       fire_and_forget(_fire_and_forget_cmd)
 
 # Threaded callback class
 class ThreadFunction():
@@ -100,6 +112,13 @@ class ThreadFunction():
                self._q.put((ThreadFunction._CALL, arg))
        
        def stop(self):
+               # empty the queue
+               try:
+                       while True:
+                               self._q.get_nowait()
+               except queue.Empty:
+                       pass
+               # now wait till the job-in-progress is done
                self._q.put((ThreadFunction._TERM, None))
                self._t.join()