From: Constantin Berhard <constantin@exxxtremesys.lu>
Date: Sun, 20 Oct 2013 02:51:34 +0000 (+0200)
Subject: named tuples in tyshell for better readability
X-Git-Url: https://git.ralfj.de/saartuer.git/commitdiff_plain/b0d0a5fc4029d3aa82aa76006e48c00720d25b13?ds=sidebyside

named tuples in tyshell for better readability
---

diff --git a/tyshell b/tyshell
index f30b9d7..13a5513 100755
--- a/tyshell
+++ b/tyshell
@@ -7,6 +7,7 @@ import subprocess
 import socket
 import pwd
 import grp
+from collections import namedtuple
 
 tuerSock = "/run/tuer.sock"
 
@@ -22,7 +23,7 @@ atexit.register(readline.write_history_file, histfile)
 # available commands
 def helpcmd(c):
 	if (len(c) > 1):
-		print(commands.get(c[1],(None,'Can\'t find help for command %s'%(c[1])))[1])
+		print(commands.get(c[1],(None,'Can\'t find help for command %s'%(c[1]))).helpstring)
 	else:
 		print("Available commands: %s" % ", ".join(sorted(commands.keys())))
 		print("Use 'help command' to get more information on the command 'command'")
@@ -60,12 +61,14 @@ def alias (cmds, aliases):
 		cmds[newname] = cmds[oldname]
 	return cmds
 
+CmdEntry = namedtuple('CmdEntry','function helpstring')
+
 commands = alias({
-	'exit': (exitcmd, 'Quits this shell'),
-	'help': (helpcmd, 'Helps you getting to know the available commands'),
-	'open': (sendcmd(tuerSock, 'unlock'), 'Will try to unlock the apartment door'),
-	'buzz': (sendcmd(tuerSock, 'buzz'), 'Will buzz the buzzer for the street door'),
-	'who': (whocmd, 'Shows the list of people, who are allowed to control this system'),
+	'exit': CmdEntry(exitcmd, 'Quits this shell'),
+	'help': CmdEntry(helpcmd, 'Helps you getting to know the available commands'),
+	'open': CmdEntry(sendcmd(tuerSock, 'unlock'), 'Will try to unlock the apartment door'),
+	'buzz': CmdEntry(sendcmd(tuerSock, 'buzz'), 'Will buzz the buzzer for the street door'),
+	'who': CmdEntry(whocmd, 'Shows the list of people, who are allowed to control this system'),
 },{
 	# aliases
 	'unlock': 'open',
@@ -97,7 +100,7 @@ while True:
 		print("Command %s not found. Use help." % command[0])
 	elif len(cmdoptions) == 1: # exactly one command fits (prefix)
 		try:
-			res = commands[cmdoptions[0]][0](command)
+			res = commands[cmdoptions[0]].function(command)
 			if res: break
 		except Exception as e:
 			print("Error while executing %s: %s" % (command[0], str(e)))