From: Ralf Jung Date: Tue, 4 Aug 2015 15:18:58 +0000 (+0200) Subject: fix solution for BigInt::min. Thanks, Derek! X-Git-Url: https://git.ralfj.de/rust-101.git/commitdiff_plain/e3b3bde6ba4c44e6a53deb791bea681014b3ecab?ds=inline;hp=--cc fix solution for BigInt::min. Thanks, Derek! --- e3b3bde6ba4c44e6a53deb791bea681014b3ecab diff --git a/solutions/src/bigint.rs b/solutions/src/bigint.rs index 96958b4..5869ba8 100644 --- a/solutions/src/bigint.rs +++ b/solutions/src/bigint.rs @@ -154,16 +154,14 @@ impl Minimum for BigInt { other } else { // compare back-to-front, i.e., most significant digit first - let mut idx = self.data.len()-1; + let mut idx = self.data.len(); while idx > 0 { + idx = idx-1; if self.data[idx] < other.data[idx] { return self; } else if self.data[idx] > other.data[idx] { return other; } - else { - idx = idx-1; - } } // the two are equal return self; @@ -285,7 +283,9 @@ mod tests { let b3 = BigInt::from_vec(vec![0, 1]); assert_eq!(b1.min(&b2), &b1); + assert_eq!(b2.min(&b1), &b1); assert_eq!(b3.min(&b2), &b2); + assert_eq!(b2.min(&b3), &b2); } #[test]