X-Git-Url: https://git.ralfj.de/lilass.git/blobdiff_plain/6c00241a910d36f0d1c0cf0a1a120214f362db43..0d513b43eb63d88ff9b1262dedda26b330d2505e:/zenity_dialogue.py

diff --git a/zenity_dialogue.py b/zenity_dialogue.py
index 45cf557..69365e8 100644
--- a/zenity_dialogue.py
+++ b/zenity_dialogue.py
@@ -22,7 +22,7 @@ def userChoose (title, choices, returns, fallback):
 	assert len(choices) == len(returns)
 	p = subprocess.Popen(["zenity", "--list", "--text="+title, "--column="]+choices, stdout=subprocess.PIPE)
 	switch = dict (zip (choices,returns))
-	for line in p.stdout:
+	for line in p.stdout: # FIXME use p.communicate()[0] instead to get entire stdout and ensure the process terminates. also check p.returncode.
 		return switch.get(line.strip(), fallback)
 	return fallback