From 3a59fb5ed4a5ad3bc9bdadae9616c62f7de38fff Mon Sep 17 00:00:00 2001
From: Ralf Jung <post@ralfj.de>
Date: Mon, 15 Apr 2024 15:46:29 +0200
Subject: [PATCH] link to possible solutions that avoid --new-session

---
 profiles.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/profiles.py b/profiles.py
index 70e8b81..69445f4 100644
--- a/profiles.py
+++ b/profiles.py
@@ -9,6 +9,11 @@ DEFAULT = group(
   # However, some applications will not like this unless the hostname also exists in `/etc/hosts`!
   bwrap_flags("--unshare-uts", "--hostname", "bubblebox"),
   # Make sure the sandbox cannot inject commands into the host terminal.
+  # TODO: This flag breaks some CLI applications, like job control in shells.
+  # Consider using SECCOMP instead.
+  # Possible code to use for that: <https://gist.github.com/sloonz/4b7f5f575a96b6fe338534dbc2480a5d#file-sandbox-py-L129>
+  # There is also a good list of possible-syscalls-to-block at
+  # <https://github.com/flatpak/flatpak/blob/f16e064fd9454fb8f754b769ad1ffce0e42b51db/common/flatpak-run.c#L1791>.
   bwrap_flags("--new-session"),
   # basic directories
   bwrap_flags("--proc", "/proc", "--dev", "/dev", "--dir", "/tmp", "--dir", "/var", "--dir", "/run", "--symlink", "../run", "/var/run"),
-- 
2.30.2