X-Git-Url: https://git.ralfj.de/auto-debuild.git/blobdiff_plain/6a16ca2114768210c74541b4a882d4a8ecfc1ad6..8b398829c3062f20c42b0a5d048cc3414098cc89:/auto_debuild.py?ds=inline

diff --git a/auto_debuild.py b/auto_debuild.py
index 0c466b4..c274412 100755
--- a/auto_debuild.py
+++ b/auto_debuild.py
@@ -2,18 +2,36 @@
 import os, stat, time, subprocess, sys
 from collections import OrderedDict
 
+# some utility functions
+def safeCall(args):
+	res = ""
+	for arg in args:
+		assert arg.find("'") < 0 # ' is not supported
+		if len(res): res += " "
+		res += "'"+arg+"'"
+	return res
+
 # abstract representation of rules file
 class RulesFile:
 	def __init__(self):
-		self.env = []
+		self.env = {}
 		self.dh = []
 		self.rules = OrderedDict()
 	
+	def env2str(self):
+		res = ""
+		for name in self.env: # we rely on the name being sane (i.e., no special characters)
+			val = self.env[name]
+			assert val.find("'") < 0 # ' is not supported
+			if len(res): res += " "
+			res += name+"='"+val+"'"
+		return res
+
 	def write(self, f):
 		print >>f, "#!/usr/bin/make -f"
 		print >>f, ""
 		print >>f, "%:"
-		print >>f, '\t'+' '.join(self.env)+' dh $@',' '.join(self.dh)
+		print >>f, '\t'+self.env2str()+' dh $@ '+safeCall(self.dh)
 		for rule in self.rules:
 			print >>f, ""
 			print >>f, "override_dh_"+rule+":"
@@ -22,13 +40,16 @@ class RulesFile:
 
 # build-system specific part of rules file
 def cmakeRules(config):
+	buildDir = config.get('buildDir', 'build.dir') # "build" is not a good idea, as that's also the name of a target...
+	srcDir = os.getcwd()
 	r = RulesFile()
-	r.dh += ["--buildsystem=cmake", "--builddirectory=build.dir"] # dh parameters: "build" is not a good idea, as that's also the name of a target...
+	r.dh += ["--buildsystem=cmake", "--builddirectory="+buildDir] # dh parameters
 	r.rules['auto_configure'] = [
-		'mkdir -p build.dir',
-		"cd build.dir && cmake .. -DCMAKE_INSTALL_PREFIX=/usr "+' '.join(config.get('cmakeParameters', []))
+		safeCall(["mkdir", "-p", buildDir]),
+		safeCall(["cd", buildDir]) + " && " +
+		  safeCall(["cmake", srcDir, "-DCMAKE_INSTALL_PREFIX=/usr"] + config.get('cmakeParameters', []))
 	]
-	r.rules['auto_clean'] = ['rm -f build.dir/CMakeCache.txt'] # clean old cmake cache
+	r.rules['auto_clean'] = [safeCall(['rm', '-f', os.path.join(buildDir, 'CMakeCache.txt')])] # clean old cmake cache
 	return r
 
 def automakeRules(config):
@@ -37,13 +58,13 @@ def automakeRules(config):
 	r.rules['auto_configure'] = [
 		'BUILD_TYPE=$$(dpkg-architecture -qDEB_BUILD_GNU_TYPE) && ' + # doing the expansion beforehand ensures that we cancel if it fails
 		'MULTIARCH=$$(dpkg-architecture -qDEB_BUILD_MULTIARCH) && '+
-			'./configure --build=$$BUILD_TYPE ' +
-			'--prefix=/usr --includedir=/usr/include --mandir=/usr/share/man --infodir=/usr/share/info ' +
+			'./configure --build=$$BUILD_TYPE '+ # do the escape manually here so we can use the variables (there's no user-controlled string in here anyway)
+			'--prefix=/usr --includedir=/usr/include --mandir=/usr/share/man --infodir=/usr/share/info '+
 			'--libdir=/usr/lib/$$MULTIARCH --libexecdir=/usr/lib/$$MULTIARCH '+
-			'--sysconfdir=/etc --localstatedir=/var ' +
-			' '.join(config.get('automakeParameters', []))
+			'--sysconfdir=/etc --localstatedir=/var '+
+			safeCall(config.get('automakeParameters', []))
 	]
-	r.rules['auto_clean'] = ['rm -f config.status'] # do not re-use old configuration
+	r.rules['auto_clean'] = ['rm -f config.status'] # do not re-use old configuration (no need for escaping here, obviously)
 	return r
 
 # utility functions
@@ -59,8 +80,9 @@ def getArchitecture(config):
 	if p.returncode != 0: raise Exception("Querying dpkg for the architecture failed")
 	return res[0:len(res)-1] # chop of the \n at the end
 
-def writeDebList(list):
-	return ', '.join(list)
+def writeDependency(f, name, list):
+	if len(list):
+		print >>f, name+": "+', '.join(list)
 
 # actual work functions
 def createDebianFiles(config):
@@ -72,12 +94,17 @@ def createDebianFiles(config):
 	buildSystem = config['buildSystem']
 	version = config['version']
 	dbgPackage = config.get('dbgPackage', False)
+	parallelJobs = int(config.get('parallelJobs', 2))
 	packageArchitecture = config.get('architecture', 'any')
 	# we return the list of files generated, so we need to know the architecture
 	arch = getArchitecture(config)
 	files = []
+	# create folders
+	if os.path.exists('debian'): raise Exception('debian folder already exists?')
+	os.mkdir('debian')
+	os.mkdir('debian/source')
+	if not os.path.exists(debDir): os.mkdir(debDir)
 	# source format file
-	if not os.path.exists('debian/source'): os.mkdir('debian/source')
 	with open('debian/source/format', 'w') as f:
 		print >>f, "3.0 (native)"
 	# compat file
@@ -99,13 +126,15 @@ def createDebianFiles(config):
 		print >>f, "Section:",config.get('section', 'misc')
 		print >>f, "Priority: extra"
 		print >>f, "Maintainer: %s <%s>" % (name, email)
-		print >>f, "Build-Depends:",writeDebList(["debhelper (>= 9)"] + config.get('buildDepends', []))
+		writeDependency(f, 'Build-Depends', ["debhelper (>= 9)"] + config.get('buildDepends', []))
 		print >>f, "Standards-Version: 3.9.3"
 		print >>f, ""
 		print >>f, "Package:",binaryName
 		print >>f, "Architecture:",packageArchitecture
-		print >>f, "Depends:",writeDebList(["${shlibs:Depends}", "${misc:Depends}"] + config.get('binaryDepends', []))
-		print >>f, "Provides:",writeDebList(config.get('binaryProvides', [sourceName]))
+		writeDependency(f, "Pre-Depends", ["${misc:Pre-Depends}"] + config.get('binaryPreDepends', []))
+		writeDependency(f, "Depends", ["${shlibs:Depends}", "${misc:Depends}"] + config.get('binaryDepends', []))
+		writeDependency(f, "Recommends", config.get('binaryRecommends', []))
+		writeDependency(f, "Provides", config.get('binaryProvides', [sourceName]))
 		print >>f, "Description:",sourceName,"(auto-debuild)"
 		print >>f, " Package auto-generated by auto-debuild."
 		files.append(os.path.join(debDir, "%s_%s_%s.deb" % (binaryName, version, arch)))
@@ -113,10 +142,14 @@ def createDebianFiles(config):
 			print >>f, ""
 			print >>f, "Package:",binaryName+"-dbg"
 			print >>f, "Architecture:",packageArchitecture
-			print >>f, "Depends:",writeDebList(["${misc:Depends}", binaryName+" (= ${binary:Version})"])
+			writeDependency(f, "Depends", ["${misc:Depends}", binaryName+" (= ${binary:Version})"])
 			print >>f, "Description:",sourceName,"debug smbols (auto-debuild)"
 			print >>f, " Package containing debug symbols for "+sourceName+", auto-generated by auto-debuild."
 			files.append(os.path.join(debDir, "%s-dbg_%s_%s.deb" % (binaryName, version, arch)))
+	# install file
+	with open('debian/'+binaryName+'.install', 'w') as f:
+		for line in config.get('binaryInstall', []):
+			print >>f, line
 	# rules file: build system specific
 	with open('debian/rules', 'w') as f:
 		# get rule file for build system: may only touch auto_config and auto_clean rules and the dh options
@@ -127,16 +160,23 @@ def createDebianFiles(config):
 		else:
 			raise Exception("Invalid build system "+buildSystem)
 		# global rules
-		r.env += ["DEB_BUILD_OPTIONS='parallel=2'"]
-		if not dbgPackage: r.env += ["DEB_CFLAGS_APPEND='-g0'", "DEB_CXXFLAGS_APPEND='-g0'"] # disable debug information
+		r.env["DEB_BUILD_OPTIONS"] = 'parallel='+str(parallelJobs)
+		if not dbgPackage:
+			# disable debug information
+			r.env["DEB_CFLAGS_APPEND"] = '-g0'
+			r.env["DEB_CXXFLAGS_APPEND"] = '-g0'
 		r.dh += ['--parallel']
-		r.rules['builddeb'] = ['dh_builddeb --destdir='+debDir] # passing this gobally to dh results in weird problems (like stuff being installed there, and not in the package...)
+		r.rules['builddeb'] = [safeCall(['dh_builddeb', "--destdir="+debDir])] # passing this gobally to dh results in weird problems (like stuff being installed there, and not in the package...)
 		r.rules['auto_test'] = []
-		r.rules['auto_install'] = ['dh_auto_install --destdir=debian/'+binaryName] # install everything into the binary package
+		# installation rule
+		r.rules['auto_install'] = [safeCall(['dh_auto_install', '--destdir=debian/'+binaryName])] # install everything into the binary package
+		if 'binarySkipFiles' in config:
+			r.rules['auto_install'].append(safeCall(['cd', 'debian/'+binaryName]) + " && " +
+				safeCall(['rm'] + config['binarySkipFiles']))
 		# for debug packages
 		if dbgPackage:
-			r.rules['strip'] = ['dh_strip --dbg-package='+binaryName+"-dbg"] # put debug files in appropriate package
-			r.rules['installdocs'] = ['dh_installdocs --link-doc='+binaryName] # make the doc folder of the dbg package a symlink
+			r.rules['strip'] = [safeCall(['dh_strip', '--dbg-package='+binaryName+"-dbg"])] # put debug files in appropriate package
+			r.rules['installdocs'] = [safeCall(['dh_installdocs', '--link-doc='+binaryName])] # make the doc folder of the dbg package a symlink
 		# dump it to a file
 		r.write(f)
 	mode = os.stat('debian/rules').st_mode
@@ -146,15 +186,22 @@ def createDebianFiles(config):
 
 def buildDebianPackage(config):
 	commands = ['dpkg-checkbuilddeps', 'debian/rules clean', 'debian/rules build', 'fakeroot debian/rules binary', 'debian/rules clean']
-	command = ['bash', '-c', ' && '.join(commands)]
+	command = ['nice', 'bash', '-c', ' && '.join(commands)]
 	subprocess.check_call(commandInBuildEnv(config, command))
+	shutil.rmtree('debian') # it only contains what we just created
 
+###################################################################
 # if we are called directly as script
 if __name__ == "__main__":
+	import imp, shutil
+	# get config
+	config = imp.load_source('config', 'auto-debuild.conf').__dict__
+	os.remove('auto-debuild.confc')
 	# generate debian files
-	import imp
-	config = imp.load_source('config', 'debian/auto-debuild.conf').__dict__
-	os.remove('debian/auto-debuild.confc')
+	if os.path.exists('debian'):
+		if raw_input("A debian folder already exists, to you want to remove it (y/N)? ").lower() != "y":
+			sys.exit(1)
+		shutil.rmtree('debian')
 	files = createDebianFiles(config)
 	# check if a file is overwritten
 	for file in files:
@@ -164,4 +211,5 @@ if __name__ == "__main__":
 	# run compilation
 	buildDebianPackage(config)
 	# install files
+	print "Installing created deb files..."
 	subprocess.check_call(['sudo', 'dpkg', '--install'] + files)